Add basic unit tests for problem::normalized. #120

neduard · 2015-03-10T22:50:43Z

Unit test for problem::normalized.
Test that applying normalize to a problem with bounds (-1, 1) doesn't have any effect.
Ensure that no matter what the bounds, normalized.objfun(x) = original.objfun(denormalize(x))

This PR is part of issue #7

Use `is_eq` function; Create local copy of problem under test; Rename variables to be consistent with naming scheme; Add comments.

neduard · 2015-03-12T18:22:27Z

A couple of questions:

should we include tests for normalized::compute_constraints_impl() ?
normalized::denormalize(const decision_vector& x) does NOT check that x is actually normalized: https://github.com/esa/pagmo/blob/master/src/problem/normalized.cpp#L77-83 is this the correct behaviour?

darioizzo · 2015-03-12T18:31:34Z

Yes, same as objfun_impl
good point, as the method is public a check and a pagmo_throw should be there. On the other hand, it is used by the private methods compute_constraints_impl and objfun_impl so this would trigger a lot of checks ... I doubt it would see any performance impact in any realistic case ....

krzysztof · 2015-03-13T14:56:55Z

tests/test_normalized.cpp

+// Test following invariant:
+// normalized(prob).objfun(dv) is equal to
+//   prob.objfun(normalized(prob).denormalize(dv))
+int test_normalized_invariant(


Merge the lines here 63 and 64 (I know I didn't give you a clear guidelines on character limit ;) )

Method/Functions commenting style is either: https://github.com/esa/pagmo/blob/master/src/problem/normalized.cpp#L35-L41
or triple slash like https://github.com/esa/pagmo/blob/master/src/problem/normalized.cpp#L58
Latter is fine for unit testing.

landscape-bot · 2015-04-22T14:23:36Z

Code quality remained the same when pulling 445d66c on neduard:unit_test_normalize into 3ee3b0a on esa:master.

neduard added 7 commits March 10, 2015 22:34

Add basic unit test for problem::normalized.

e4a61ce

Minor changes.

902d0cf

Use `is_eq` function; Create local copy of problem under test; Rename variables to be consistent with naming scheme; Add comments.

Add extra information of why a test failed.

480262d

Add test for normalize invariant.

60b252b

Add problems with extreme bounds.

29f9506

Formatting.

cd54ffb

Comments.

31632d8

neduard changed the title ~~DO NOT MERGE YET: Add basic unit test for problem::normalized.~~ Add basic unit tests for problem::normalized. Mar 12, 2015

krzysztof reviewed Mar 13, 2015
View reviewed changes

neduard added 5 commits March 13, 2015 19:52

bugfix: Add missing brackets and correct lower bound.

4ee738d

Add check for compute_constraints() invariant.

56d0ec9

Comments.

30f5160

Add test to ensure denormalize() performs sanity checking on input.

544ffb4

Strings, formatting.

6979c07

neduard mentioned this pull request Mar 13, 2015

Ensure that denormalize input is valid. #127

Closed

neduard added 4 commits March 13, 2015 20:48

Merge branch 'master' into unit_test_normalize

8032c7f

Merge branch 'master' into unit_test_normalize

fd4d21e

Do not redefine helper functions: include "test.h" instead.

9c7f07a

Output test failures.

445d66c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic unit tests for problem::normalized. #120

Add basic unit tests for problem::normalized. #120

neduard commented Mar 10, 2015

neduard commented Mar 12, 2015

darioizzo commented Mar 12, 2015

krzysztof Mar 13, 2015

landscape-bot commented Apr 22, 2015

Add basic unit tests for problem::normalized. #120

Are you sure you want to change the base?

Add basic unit tests for problem::normalized. #120

Conversation

neduard commented Mar 10, 2015

neduard commented Mar 12, 2015

darioizzo commented Mar 12, 2015

krzysztof Mar 13, 2015

Choose a reason for hiding this comment

landscape-bot commented Apr 22, 2015